Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit hook failures #255

Closed

Conversation

kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Jul 18, 2023

This PR resolves problems with pre-commit hooks.

  • The pre-commit hook versions are very out-of-date. The first commit updates them using pre-commit autoupdate.
  • tox -e format disagreed with the pre-commit hook reorder_python_imports. A commit replaces the pre-commit hook with an isort hook so there are no disagreements.
  • pyupgrade was targeting Python 3.7 syntax, but Quart requires Python 3.8 or higher. A commit updates pyupgrade to target Python 3.8 syntax.
  • pre-commit run --all-files was run twice to catch and fix most issues.
  • Flake8 failures were then manually resolved.

The test suite continues to fail due to mypy issues and a missing toml dependency. Merge #254 to resolve the toml failure.

Also, I recommend enabling pre-commit.ci for this repo.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@kurtmckee kurtmckee changed the title Fix pre commit hook failures Fix pre-commit hook failures Jul 18, 2023
@pgjones
Copy link
Member

pgjones commented Sep 5, 2023

Thanks I've merged most of this manually.

@pgjones pgjones closed this Sep 5, 2023
@kurtmckee kurtmckee deleted the fix-pre-commit-hook-failures branch September 5, 2023 21:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants