-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REQUEST_URI should preserve the query string #1781
Milestone
Comments
I can't reproduce this issue. I ran the following example and got the full unquoted path and query. from pprint import pformat
from werkzeug import Request, Response, run_simple
@Request.application
def app(request):
return Response(pformat(request.environ))
if __name__ == "__main__":
run_simple("localhost", 5000, app) Navigating to |
#1782 shows that this is about the test client, not the dev server. |
Working on this. |
kx-chen
added a commit
to MLH-Fellowship/werkzeug
that referenced
this issue
Jun 18, 2020
kx-chen
added a commit
to MLH-Fellowship/werkzeug
that referenced
this issue
Jun 18, 2020
kx-chen
added a commit
to MLH-Fellowship/werkzeug
that referenced
this issue
Jun 18, 2020
kx-chen
added a commit
to MLH-Fellowship/werkzeug
that referenced
this issue
Jun 18, 2020
kx-chen
added a commit
to MLH-Fellowship/werkzeug
that referenced
this issue
Jun 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
REQUEST_URI was introduced by #1419: 7162f43
Currently, Werkzeug strips the query string. While REQUEST_URI is not a standard variable, I believe the consensus is to include the query string. According to #766 (comment) that should have be the case for Werkzeug too.
That applies to RAW_URI too.
It’s an edge case, but ideally empty query strings like in
/?
should be preserved too and not simplified to/
.The text was updated successfully, but these errors were encountered: