Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket requests from Firefox fail with a 400 error #2131

Closed
miguelgrinberg opened this issue May 17, 2021 · 0 comments · Fixed by #2136
Closed

WebSocket requests from Firefox fail with a 400 error #2131

miguelgrinberg opened this issue May 17, 2021 · 0 comments · Fixed by #2136
Milestone
2.0.2

Comments

@miguelgrinberg
Copy link
Contributor

Firefox issues their WebSocket requests with the following connection header:

Connection: keep-alive, Upgrade

While Chrome and other browsers do:

Connection: Upgrade

The WebSocket routing logic needs to be made more robust to accept the general format of the Connection header. I will work on this fix and submit a PR in the next few days.

Environment:

  • Python version: Any
  • Werkzeug version: 2.0.0
@miguelgrinberg miguelgrinberg mentioned this issue May 17, 2021
Closed
miguelgrinberg added a commit to miguelgrinberg/werkzeug that referenced this issue May 17, 2021
@miguelgrinberg
Handle multiple tokens in Connection header (Fixes pallets#2131)
b270c95
miguelgrinberg added a commit to miguelgrinberg/werkzeug that referenced this issue May 17, 2021
@miguelgrinberg
Handle multiple tokens in Connection header (Fixes pallets#2131)
8df1002
miguelgrinberg added a commit to miguelgrinberg/werkzeug that referenced this issue May 17, 2021
@miguelgrinberg
Handle multiple tokens in Connection header (Fixes pallets#2131)
d365c10
@miguelgrinberg miguelgrinberg mentioned this issue May 17, 2021
Merged
6 tasks
miguelgrinberg added a commit to miguelgrinberg/werkzeug that referenced this issue May 18, 2021
@miguelgrinberg
Handle multiple tokens in Connection header (Fixes pallets#2131)
286cd04
miguelgrinberg added a commit to miguelgrinberg/werkzeug that referenced this issue May 18, 2021
@miguelgrinberg
Handle multiple tokens in Connection header (Fixes pallets#2131)
d715397
miguelgrinberg added a commit to miguelgrinberg/werkzeug that referenced this issue May 18, 2021
@miguelgrinberg
Handle multiple tokens in Connection header (Fixes pallets#2131)
04b56a2
miguelgrinberg added a commit to miguelgrinberg/werkzeug that referenced this issue May 18, 2021
@miguelgrinberg
Handle multiple tokens in Connection header (Fixes pallets#2131)
27b990b
@davidism davidism added this to the 2.0.2 milestone May 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.2
Development

Successfully merging a pull request may close this issue.

Handle multiple tokens in Connection header when routing WebSocket miguelgrinberg/werkzeug
2 participants
@davidism @miguelgrinberg