Improve types for AST handling #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
commented
May 18, 2024
src/werkzeug/routing/rules.py
Outdated
| @@ -815,13 +826,13 @@ def _join(parts: list[ast.AST]) -> ast.AST: | |||
| # bad line numbers cause an assert to fail in debug builds | |||
| for node in ast.walk(module): | |||
| if "lineno" in node._attributes: | |||
| node.lineno = 1 | |||
| node.lineno = 1 # type: ignore[attr-defined] | |||
There was a problem hiding this comment.
These type ignores show up as unused right now with the current version of typeshed; I'll just remove them and they can be added when you pull in the new version of mypy.
|
Is this new mypy released yet? I just updated mypy to 1.10 and it seems to pass without this change, but perhaps it's not out yet. |
|
It's not out, this is related to a typeshed PR that I merged earlier today. The relevant changes should be in the next mypy release. |
Adapting to changes in python/typeshed#11880. This mostly adds more precise types for individual pieces of AST.
for more information, see https://pre-commit.ci
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting to changes in python/typeshed#11880. This mostly adds
more precise types for individual pieces of AST.
This change fixes typechecking issues that will show up when you next upgrade mypy.