Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove xprocess from the tests #2908

Closed
wants to merge 17 commits into from
Closed

feat: remove xprocess from the tests #2908

wants to merge 17 commits into from

Conversation

sp6370
Copy link
Contributor

@sp6370 sp6370 commented May 20, 2024

Fix: #2906

sp6370 and others added 17 commits May 20, 2024 14:35
@sp6370
feat: remove xprocess from the tests
66097f9
@sp6370
chore: formatting change
d7d892f
@sp6370
chore: update the wait_for_log
d35da5e
@sp6370
chore: update the wait_for_server
c4fb8aa
@sp6370
chore: update the start_dev_server
50b3db2
@sp6370
chore: update the DevServerClient
0a59b3e
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b3579be 
for more information, see https://pre-commit.ci
@sp6370
chore: update the tests and supporting functions
21d1438
@sp6370
chore: update the get_logs
5dccbe4
@sp6370
chore: update the test to use get_logs
b4f0e94
@sp6370
chore: update the pytest teardown for dev_server
f2ffe62
@sp6370
chore: update the timeout for get_logs
4f636ee
@sp6370
chore: update wait_for_log to use bytes
d5cb981
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a7f0317 
for more information, see https://pre-commit.ci
@sp6370
chore: update the exception handling
219e3d3
@sp6370
chore: update the wait_for_server
d644a02
@sp6370
chore: update the start_dev_server
bc24fe3
@davidism
Copy link
Member

davidism commented May 21, 2024 •
edited
Loading

Found that passing -u to python will allow using p.stdout.readline() without waiting for the whole process to finish. I also tried passing bufsize=0 to Popen but that didn't work.

subprocess.Popen([sys.executable, "-u", "run.py", ...], ...)

@davidism
Copy link
Member

continued in #2963

@davidism davidism closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace pytest-xprocess
2 participants
@sp6370 @davidism