Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed automatic quotes choice in few cases #243

Merged
merged 1 commit into from
May 4, 2024

Conversation

pamburus
Copy link
Owner

@pamburus pamburus commented May 4, 2024

Fixes

  • Backticks were selected if string contained only single quotes and no other special characters
  • Single quotes were selected if string contained backslashes

Now

  • Now double quotes are selected if string contains only single quotes
  • Now backticks are selected if string contains backslashes but no backticks

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.38%. Comparing base (834b33a) to head (ec9ed94).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   54.61%   56.38%   +1.76%     
==========================================
  Files          38       38              
  Lines        9473     9629     +156     
==========================================
+ Hits         5174     5429     +255     
+ Misses       4299     4200      -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pamburus pamburus marked this pull request as ready for review May 4, 2024 16:18
@pamburus pamburus merged commit 67899b5 into master May 4, 2024
7 checks passed
@pamburus pamburus deleted the feature/auto-quotes branch May 4, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant