Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 error handling #16

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Add S3 error handling #16

merged 6 commits into from
Oct 19, 2022

Conversation

aschenbecherwespe
Copy link
Contributor

@aschenbecherwespe aschenbecherwespe commented Oct 19, 2022

Closes #

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md have been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Add feature to abstract Minio.S3Errors away from the user.

What is the current behavior?

Raise a Minio error when data not found.

What is the new behavior?

Raise a DriftClientError.

Does this PR introduce a breaking change?

No

Other information:

@atimin atimin changed the title add s3 error handling Add s3 error handling Oct 19, 2022
@atimin atimin changed the title Add s3 error handling Add S3 error handling Oct 19, 2022
@atimin atimin merged commit dcbbfd2 into develop Oct 19, 2022
@atimin atimin deleted the DRIFT-550 branch October 19, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants