Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Styler.apply() to accept keyword arguments #921

Merged
merged 3 commits into from
May 13, 2024

Conversation

Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented May 12, 2024

@Dr-Irv Dr-Irv requested a review from twoertwein May 12, 2024 20:40
@@ -40,6 +41,16 @@ from pandas.io.formats.style_render import (
Subset,
)

class SeriesFunc(Protocol):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer renaming it to _SeriesFunc or put it in _typing so that users don't think they can import it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Done in commit 63ea146

@twoertwein twoertwein merged commit ad4066a into pandas-dev:main May 13, 2024
13 checks passed
@twoertwein
Copy link
Member

Thank you @Dr-Irv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants