Skip to content

Conversation

orbitfold
Copy link
Contributor

No description provided.

@wesm wesm merged commit f09b6a6 into pandas-dev:master Jul 11, 2012
@wesm
Copy link
Member

wesm commented Jul 11, 2012

A couple of comments and I'm going to make some quick edits.

@wesm
Copy link
Member

wesm commented Jul 11, 2012

Also here's a more pandas-ian way for the following few lines:

    if cols is None:
        columns = data.drop(class_column, axis=1)
    else:
        columns = data[cols]

instead of

    if cols is None:
        columns = [data[col] for col in data.columns if (col != class_column)]
    else:
        columns = data[cols] [data[col] for col in cols]

@orbitfold
Copy link
Contributor Author

I see. This pattern is also in most other of my multi-variate data visualization routines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants