Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access git revision of currently running pandas #21295

Closed
jangorecki opened this issue Jun 2, 2018 · 10 comments

Comments

Projects
None yet
5 participants
@jangorecki
Copy link

commented Jun 2, 2018

I would like to know from inside the code which pandas git revision I am running at the moment. So I can easily confirm I am on proper branch/revision when testing some new features/bug fixes.
Is it possible in pandas? If it isn't I would like this issue to be FR for such functionality. Just git commit hash is enough.
In dask you can access this info with dask.__git_revision__.

@WillAyd

This comment has been minimized.

Copy link
Member

commented Jun 2, 2018

I'm not very clear on the use case here - can you provide a concrete example of how this would be useful?

@WillAyd WillAyd added the Needs Info label Jun 2, 2018

@jangorecki

This comment has been minimized.

Copy link
Author

commented Jun 3, 2018

most common:

easily confirm I am on proper branch/revision when testing some new features/bug fixes

more complex would be to process pipelines using different versions of pandas simultaneously, so auditing git revision from each job in a pipeline.

@jorisvandenbossche

This comment has been minimized.

Copy link
Member

commented Jun 3, 2018

Pandas development version already gives an abbreviated form of the git revision:

In [1]: pd.__version__
Out[1]: '0.24.0.dev0+54.g10aab3c'

That's not sufficient?

@jangorecki

This comment has been minimized.

Copy link
Author

commented Jun 5, 2018

It is good but not sufficient. It still requires lookup to git repo to get commit sha.

@TomAugspurger

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2018

@TomAugspurger

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2018

@jangorecki could you make a PR implementing this?

@jangorecki

This comment has been minimized.

Copy link
Author

commented Jun 27, 2018

@TomAugspurger not anytime soon

@atulagrwl

This comment has been minimized.

Copy link

commented Jun 29, 2018

Added pd.__git_version__ to reflect git sha commit version.

atulaggarwal pushed a commit to atulagrwl/pandas that referenced this issue Jun 30, 2018

atulaggarwal pushed a commit to atulagrwl/pandas that referenced this issue Jun 30, 2018

atulaggarwal pushed a commit to atulagrwl/pandas that referenced this issue Jul 1, 2018

@jangorecki

This comment has been minimized.

Copy link
Author

commented Sep 10, 2018

@atulagrwl any reason why this was not yet merged?

@TomAugspurger

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2018

@jangorecki the PR is still open, and currently has a merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.