New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional ./ci/code_checks.sh pre-commit #36956

Closed

MarcoGorelli opened this issue Oct 7, 2020 · 1 comment

Labels

Code Style

Member

MarcoGorelli commented Oct 7, 2020

xref #36722 (comment)

Is there a way to have an option in code_checks.sh that actually runs the appropriate pre-commit hook? that way we have a single source of truth, and you can actually still run them (of course have to avoid running these on the CI from the script as well)

MarcoGorelli added the Code Style label

MarcoGorelli mentioned this issue

CI unpin flake8, only run flake8-rst in pre-commit #36722

Merged

5 tasks

simonjayhawkins added this to the Contributions Welcome milestone

Member Author

MarcoGorelli commented Jul 16, 2021

closing as by now pre-commit run --all-files has become the single source of truth

MarcoGorelli closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment