Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: DataFrame.idxmin/idxmax with mixed dtypes #38195

Merged
merged 6 commits into from
Dec 2, 2020
Merged

BUG: DataFrame.idxmin/idxmax with mixed dtypes #38195

merged 6 commits into from
Dec 2, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 30, 2020 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added Bug Reduction Operations sum, mean, min, max, etc. labels Dec 2, 2020
@jreback jreback added this to the 1.2 milestone Dec 2, 2020
@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

looks good. merge master and ping on green (CI hanging)

@simonjayhawkins
Copy link
Member

@jreback green

@jreback jreback merged commit 4749fd6 into pandas-dev:master Dec 2, 2020
@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the enh-idxmax branch December 2, 2020 14:49
@jbrockmendel jbrockmendel mentioned this pull request Dec 3, 2020
Closed
@MarcoGorelli MarcoGorelli mentioned this pull request Mar 13, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Reduction Operations sum, mean, min, max, etc.
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbrockmendel @jreback @simonjayhawkins