API: CategoricalDtype.__eq__ with categories=None stricter #38516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Dec 16, 2020
jreback
added
Categorical
|
ok this looks good. though having a hard time telling what changed from a user POV, can you add a whatsnew note. |
|
whatsnew added + greenish |
|
can you rebase |
jreback
approved these changes
Dec 22, 2020
|
rebased + greenish |
|
excellent. this blocked #38530, which in turn is one of only two remaining special cases preventing us from ripping out Block._astype |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffxref #37929
This will allow us to remove special-casing for Categorical in Block._astype, Index.astype, and Categorical.astype.