Skip to content

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 29, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

This started off with editing na_value_for_dtype so that it could be re-used in #39446, ended up snowballing into assert_attr_equal. If requested, I'll split off the bugfix into its own PR.

@jreback jreback added Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Feb 2, 2021
@jreback jreback added this to the 1.3 milestone Feb 2, 2021
@jreback
Copy link
Contributor

jreback commented Feb 2, 2021

looks fine. can you add a whatsnew note for the user.

@jreback jreback merged commit 48f73d8 into pandas-dev:master Feb 2, 2021
@jbrockmendel jbrockmendel deleted the ref-na_value_for_dtype branch February 2, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants