Skip to content

Conversation

jbrockmendel
Copy link
Member

from asv_bench.benchmarks.groupby import *
self = Apply()
self.setup(4)

%timeit self.time_copy_function_multi_col(4)
451 ms ± 2.2 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)  # <- PR
559 ms ± 1.35 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)  # <- master

@mzeitlin11
Copy link
Member

There's an issue #38358 about the commit that added this filter causing a perf regression, would this fix that?

@jbrockmendel
Copy link
Member Author

I think so yes.

@jreback jreback added Apply Apply, Aggregate, Transform, Map Groupby Performance Memory or execution speed performance labels Sep 15, 2021
@jreback jreback added this to the 1.4 milestone Sep 15, 2021
@jreback jreback merged commit 0914808 into pandas-dev:master Sep 15, 2021
@jbrockmendel jbrockmendel deleted the perf-no-filter branch September 15, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Groupby Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants