Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: args and kwargs in rolling, expanding, and ewm ops #47851

Merged
merged 4 commits into from
Jul 29, 2022

Conversation

rhshadrach
Copy link
Member

We can't call maybe_warn_args_and_kwargs any further in the stack (e.g. in _apply) because args aren't passed along.

@rhshadrach rhshadrach added Numeric Operations Arithmetic, Comparison, and Logical operations Deprecate Functionality to remove in pandas Window rolling, ewma, expanding labels Jul 25, 2022
@rhshadrach
Copy link
Member Author

The numeric_only argument in Expanding.sem was missing. The tests for numeric_only passed because we were still passing through as a kwarg. So no additional tests for this argument are needed.

@mroeschke mroeschke added this to the 1.5 milestone Jul 26, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @jreback for the go-ahead to deprecate *args/**kwargs here

@jreback jreback merged commit 23c53bb into pandas-dev:main Jul 29, 2022
@jreback
Copy link
Contributor

jreback commented Jul 29, 2022

thanks @rhshadrach very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Numeric Operations Arithmetic, Comparison, and Logical operations Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: rolling, expanding, and ewm args and kwargs
3 participants