Skip to content

BUG: MultiIndex.difference not keeping ea dtype #48606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 23, 2022
Merged

BUG: MultiIndex.difference not keeping ea dtype #48606

merged 11 commits into from
Sep 23, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Sep 17, 2022 •
edited
Loading

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
       before           after         ratio
     [b5632fb3]       [c8b6d846]
     <deprecation_notes~1>       <diff>    
-     5.67±0.08ms       4.73±0.1ms     0.83  multiindex_object.Difference.time_difference('string')
-     4.65±0.01ms      3.71±0.03ms     0.80  multiindex_object.Difference.time_difference('int')
-     4.78±0.02ms      3.75±0.01ms     0.78  multiindex_object.Difference.time_difference('ea_int')
-     6.35±0.02ms      4.85±0.02ms     0.76  multiindex_object.Difference.time_difference('datetime')

@phofl phofl added MultiIndex NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Sep 17, 2022
mroeschke
mroeschke reviewed Sep 19, 2022
View reviewed changes
@phofl phofl mentioned this pull request Sep 23, 2022
Closed
4 tasks
@mroeschke mroeschke added this to the 1.6 milestone Sep 23, 2022
@mroeschke mroeschke merged commit 44a4f16 into pandas-dev:main Sep 23, 2022
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the diff branch September 23, 2022 22:00
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@phofl @noatamir
BUG: MultiIndex.difference not keeping ea dtype (pandas-dev#48606)
8aa6cac 
* BUG: MultiIndex.difference not keeping ea dtype

* Add asv

* Add whatsnew

* Reduce asv

* Ad ea asv

* Fix mypy

* Add whatsnew

* Fix mypy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
MultiIndex NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke