Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: Improve performance for MultiIndex.isin #48622

Merged
merged 3 commits into from
Sep 19, 2022
Merged

PERF: Improve performance for MultiIndex.isin #48622

merged 3 commits into from
Sep 19, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Sep 18, 2022

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
       before           after         ratio
     [85246fe4]       [d6015d67]
     <sym_diff^2>       <isin_performance>
-     3.48±0.01ms       3.13±0.1ms     0.90  multiindex_object.Isin.time_isin('string')
-     3.41±0.02ms      1.46±0.02ms     0.43  multiindex_object.Isin.time_isin('int')
-     10.2±0.04ms      1.54±0.02ms     0.15  multiindex_object.Isin.time_isin('datetime')

@phofl phofl added Performance Memory or execution speed performance MultiIndex labels Sep 18, 2022
@mroeschke mroeschke added this to the 1.6 milestone Sep 19, 2022
@mroeschke mroeschke merged commit 02d988c into pandas-dev:main Sep 19, 2022
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the isin_performance branch September 20, 2022 08:23
@lukemanley lukemanley mentioned this pull request Oct 1, 2022
Closed
3 tasks
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@phofl @noatamir
PERF: Improve performance for MultiIndex.isin (pandas-dev#48622)
5a81cfb 
* PERF: Improve performance for MultiIndex.isin

* PERF: Improve performance for MultiIndex.isin

* Fix gh ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
MultiIndex Performance Memory or execution speed performance
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phofl @mroeschke