DEPR: Remove NumericIndex.__new__ + related methods #51050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
changed the title
topper-123
changed the title
topper-123
changed the title
| @@ -619,6 +619,7 @@ Other API changes | |||
| new DataFrame (shallow copy) instead of the original DataFrame, consistent with other | |||
| methods to get a full slice (for example ``df.loc[:]`` or ``df[:]``) (:issue:`49469`) | |||
| - Disallow computing ``cumprod`` for :class:`Timedelta` object; previously this returned incorrect values (:issue:`50246`) | |||
| - Instantiating an :class:`Index` with an numeric numpy dtype with data containing :class:`NA` and/or :class:`NaT` now raises a ``ValueError``. Previously a ``TypeError`` was raised (:issue:`51050`) | |||
There was a problem hiding this comment.
does this match what we raise with Series or DataFrame?
There was a problem hiding this comment.
Yes, so this is also an unification wrt. the errors messages the users get, when they do this kind of mistake.
mroeschke
approved these changes
Jan 30, 2023
|
Thanks @topper-123 |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Jan 30, 2023
* Remove NumericIndex.__new__ (almost) + various methods * adds GH-number * fix errors * fix error II
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes methods
__new__,_ensure_array,_validate_dtype,_ensure_dtype&_assert_safe_castingfromNumericIndex. Also adds needed contents toIndexand other locations as needed.Some scaffolding is added to
NumericIndex.__new__, but that will be removed in the next PR.xref #42717.