BUG: DataFrame.shift(axis=1) with EADtype #53832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Jun 26, 2023
mroeschke
added
Algos
|
Thanks @jbrockmendel |
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* BUG: DataFrame.shift(axis=1) with EADtype * GH refs, final
3 tasks
5 tasks
|
Thoughts about deprecating this first? This is not great for Dask for example, since users won't be able to use older versions of dask with the new pandas version since the default for us is None which will raise |
5 tasks
|
No objection to doing this as a deprecation first (i.e. #54818) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Following this we can simplify the Manager/Block/EA methods since they will only ever get
axis=0