TYP: Update mypy and pyright #56493
Merged
TYP: Update mypy and pyright #56493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Dec 14, 2023
| # note: assumes python env is setup and activated | ||
| name: pyright reportGeneralTypeIssues | ||
| entry: pyright --skipunannotated -p pyright_reportGeneralTypeIssues.json --level warning |
There was a problem hiding this comment.
moved to pyright_reportGeneralTypeIssues.json.
twoertwein
commented
Dec 14, 2023
| max_value=pd.Timestamp(1900, 1, 1).to_pydatetime(), | ||
| min_value=pd.Timestamp( | ||
| 1900, 1, 1 | ||
| ).to_pydatetime(), # pyright: ignore[reportGeneralTypeIssues] |
There was a problem hiding this comment.
Could theoretically be NaTType
twoertwein
commented
Dec 14, 2023
twoertwein
commented
Dec 14, 2023
| @@ -39,6 +41,7 @@ | |||
| "pandas/core/arrays/string_arrow.py", | |||
| "pandas/core/arrays/timedeltas.py", | |||
| "pandas/core/computation/align.py", | |||
| "pandas/core/computation/ops.py", | |||
There was a problem hiding this comment.
This could be removed in 1.1.400
twoertwein
force-pushed
the
typing_deps
branch
from
a29eb07
to
758b6b4
Compare
twoertwein
force-pushed
the
typing_deps
branch
from
758b6b4
to
dadcf1f
Compare
twoertwein
requested review from
rhshadrach,
Dr-Irv and
MarcoGorelli
as code owners
mroeschke
added
Code Style
mroeschke
reviewed
Dec 18, 2023
mroeschke
approved these changes
Dec 19, 2023
|
Thanks @twoertwein |
cbpygit
pushed a commit
to cbpygit/pandas
that referenced
this pull request
Jan 2, 2024
* changes for mypy * changes for pyright * 1.1.400 would require too many difficult changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit contains changes for only the mypy update.
The second commit contains only changes for pyright 1.1.399 (this commit has three remaining errors caused by a bug fixed in 1.1.400 ).
The third commit tries to get to 1.1.400. One major change in 1.1.400 is that pyright now also infers missing return annotations for partially annotated functions. Many of these functions would require complex overloads or ignore codes. I added a few overloads but for now, I would prefer to update to 1.1.399 (and ignore the error fixed in 1.1.400).