TYP: make dtype required in _from_sequence_of_strings #56519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
ExtensionArray
@mroeschke is this check new? i dont see what it is complaining about |
mroeschke
reviewed
Feb 2, 2024
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
|
good suggestion, seems to have done the trick |
mroeschke
reviewed
Feb 3, 2024
| @@ -316,7 +318,7 @@ def _from_sequence( | |||
|
|
|||
| @classmethod | |||
| def _from_sequence_of_strings( | |||
| cls, strings, *, dtype: Dtype | None = None, copy: bool = False | |||
| cls, strings, *, dtype: ExtensionDtype, copy: bool = False | |||
There was a problem hiding this comment.
At least for arrow, dtype=None was supposed to mean "let pa.array infer the type", and now that can't be done?
|
This method is only ever called with a dtype object. There’s also a recent
issue about having a dedicated constructor for inference.
…On Sat, Feb 3, 2024 at 2:02 PM Matthew Roeschke ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pandas/core/arrays/arrow/array.py
<#56519 (comment)>:
> @@ -316,7 +318,7 @@ def _from_sequence(
@classmethod
def _from_sequence_of_strings(
- cls, strings, *, dtype: Dtype | None = None, copy: bool = False
+ cls, strings, *, dtype: ExtensionDtype, copy: bool = False
At least for arrow, dtype=None was supposed to mean "let pa.array infer
the type", and now that can't be done?
—
Reply to this email directly, view it on GitHub
<#56519 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UM6A7CJGWIEV5TNHGKELYR2XXLAVCNFSM6AAAAABAW7H2RSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRRGEZDQMZQG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
mroeschke
approved these changes
Feb 14, 2024
|
Thanks @jbrockmendel |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* TYP: make dtype required in _from_sequence_of_strings * GH ref * mypy fixup * Move whatsnew * Update pandas/core/arrays/base.py Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> --------- Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.