PERF: concat([Series, DataFrame], axis=0) returns RangeIndex columns when possible #58119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Reshaping
WillAyd
reviewed
Apr 3, 2024
| obj = sample._constructor({name: obj}, copy=False) | ||
| obj = sample._constructor(obj, copy=False) | ||
| if isinstance(obj, ABCDataFrame): | ||
| obj.columns = range(name, name + 1, 1) |
There was a problem hiding this comment.
What type of Index gets returned by the constructor? Shouldn't we be creating the RangeIndex at a lower level?
There was a problem hiding this comment.
._constructor with a dict would have returned an Index column with a single element name. With _constructor, there is currently no way to dictate the return type of the columns (if _constructor supports columns)
WillAyd
approved these changes
Apr 3, 2024
|
Conflict but otherwise lgtm |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…when possible (pandas-dev#58119) * PERF: concat([Series, DataFrame], axis=0) returns RangeIndex columns when possible * Add whatsnew number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #57441