Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: astype not casting values for dictionary dtype correctly #58479

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

phofl
Copy link
Member

@phofl phofl commented Apr 29, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Dtype Conversions Unexpected or buggy dtype conversions Arrow pyarrow functionality labels Apr 29, 2024
@mroeschke mroeschke added this to the 3.0 milestone Apr 29, 2024
@mroeschke mroeschke merged commit f3f3853 into pandas-dev:main Apr 29, 2024
52 of 54 checks passed
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the string_dictionary branch April 29, 2024 22:50
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…-dev#58479)

* BUG: astype not casting values for dictionary dtype correctly

* Fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants