Skip to content

Conversation

MarcoGorelli
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also be OK with doing it for level

@MarcoGorelli
Copy link
Member Author

thanks for your review

that one's not boolean and doesn't affect the return type so tbh i feel less strongly about it

@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Sep 10, 2025
@mroeschke mroeschke added this to the 3.0 milestone Sep 10, 2025
@mroeschke mroeschke merged commit 2f26644 into pandas-dev:main Sep 11, 2025
42 checks passed
@mroeschke
Copy link
Member

Thanks @MarcoGorelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants