TST: nose.SkipTest on RemoteDataErrors in tests for io.data.Options #7034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -252,8 +252,8 @@ def tearDownClass(cls): | |||
| def test_get_options_data(self): | |||
| try: | |||
| calls, puts = self.aapl.get_options_data(expiry=self.expiry) | |||
| except IndexError: | |||
| warnings.warn("IndexError thrown no tables found") | |||
| except RemoteDataError: | |||
There was a problem hiding this comment.
maybe just print the actual error in the skip too, e.g.
except RemoteDataError as e:
nose.SkipTest(e)
There was a problem hiding this comment.
Ya, thats better. Fixed that.
|
looks good.pls squash down and add a release note (ref this PR), just so we can keep track of this |
|
Squashed and added a release note. |
| @@ -424,6 +424,7 @@ Bug Fixes | |||
| - Bug in ``DataFrame.apply`` with functions that used *args or **kwargs and returned | |||
| an empty result (:issue:`6952`) | |||
| - Bug in sum/mean on 32-bit platforms on overflows (:issue:`6915`) | |||
| - Stopped tests from failing if options data isn't able to be downloaded from Yahoo (PR: #7034) | |||
There was a problem hiding this comment.
make this: (:issue:7034) ; same format as an issue
|
make that small change and rebase; ping when green |
Added to release notes Added to release notes Fixed warning tests for RemoteDataError TST: nose.Skiptest on RemoteDataErrors in tests for io.data.Options Added to release notes Conflicts: doc/source/release.rst
jreback
added a commit
that referenced
this pull request
May 5, 2014
TST: nose.SkipTest on RemoteDataErrors in tests for io.data.Options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents tests from failing if data isn't able to be downloaded from Yahoo Finance.