Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add hex color strings test #11293

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Conversation

hironow
Copy link
Contributor

@hironow hironow commented Oct 12, 2015

It's already resolved. I added hex string color test.

closes #10299

@sinhrks sinhrks added the Visualization plotting label Oct 12, 2015
@sinhrks sinhrks added this to the 0.17.1 milestone Oct 12, 2015
@sinhrks
Copy link
Member

sinhrks commented Oct 12, 2015

Thanks! This looks to be fixed by #9894.

@TomAugspurger Please merge if it looks OK.

df = pd.DataFrame(np.random.randn(5, 5))
custom_colors = ['#FF0000', '#0000FF', '#FFFF00', '#000000', '#FFFFFF']
df.plot(color=custom_colors)

2015-10-12 17 00 39

@jreback
Copy link
Contributor

jreback commented Oct 12, 2015

@hironow pls add a whats new note (bug fxies)

@hironow hironow closed this Oct 12, 2015
@hironow hironow deleted the pyconjp-2015-sprint branch October 12, 2015 19:06
@hironow
Copy link
Contributor Author

hironow commented Oct 13, 2015

Sorry, unexpectedly closed.
I tried to 'git rebase' (and replace this PR's repo) to resolve conflicts, but I deleted this by mistake.
So, what should I do about this PR?

@TomAugspurger
Copy link
Contributor

Does Github show a button for you to restore the branch?

@hironow hironow restored the pyconjp-2015-sprint branch October 13, 2015 12:35
@hironow
Copy link
Contributor Author

hironow commented Oct 13, 2015

@TomAugspurger Thanks for your comment. I restore this branch.
I've created a branch of duplicate name in my own forked repo.

@hironow hironow reopened this Oct 13, 2015
@sinhrks
Copy link
Member

sinhrks commented Oct 13, 2015

Thanks for updates. Can you squash to the single commit? You can do it by:

  1. Open your local pandas repository
  2. git checkout master to switch to master
  3. git remote add upstream https://github.com/pydata/pandas.git to register original url
  4. git pull upsream master to update your master
  5. git checkout pyconjp-2015-sprint
  6. git rebase -i master to apply the master's update to PR branch

Pls feel free to ask me if you have any question.

@hironow
Copy link
Contributor Author

hironow commented Oct 13, 2015

@sinhrks Thanks for your comment and list of git commands.
I probably was able to squash this branch.

sinhrks added a commit that referenced this pull request Oct 15, 2015
@sinhrks sinhrks merged commit c9f1a46 into pandas-dev:master Oct 15, 2015
@sinhrks
Copy link
Member

sinhrks commented Oct 15, 2015

@hironow Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use hex strings or named matplotlib colors with DataFrame.plot
4 participants