MAINT: Use check_output when merging. #14465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.25% (diff: 100%)@@ master #14465 diff @@
==========================================
Files 140 140
Lines 50655 50655
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43185 43186 +1
+ Misses 7470 7469 -1
Partials 0 0
|
Since we don't support Python 2.6 anymore, the check_output method from subprocess is at our disposal.
gfyoung
force-pushed
the
merge-pr-refactor
branch
2 times, most recently
from
3e89a37
to
e267d2b
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't support Python 2.6 anymore, the
check_outputmethod fromsubprocessisat our disposal.
Follow-up to #14447.
xref #14439 (comment)