BUG: repr SparseDataFrame after setting a value #15489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15489 +/- ##
==========================================
- Coverage 90.36% 90.36% -0.01%
==========================================
Files 136 136
Lines 49553 49551 -2
==========================================
- Hits 44781 44779 -2
Misses 4772 4772
Continue to review full report at Codecov.
|
kernc
force-pushed
the
sdf-repr
branch
2 times, most recently
from
fce521a
to
23e5f38
Compare
jreback
reviewed
Feb 24, 2017
pandas/tests/sparse/test_format.py
Outdated
| def test_sparse_repr_after_set(self): | ||
| # GH 15488 | ||
| sdf = pd.SparseDataFrame(index=[0, 1], columns=[0, 1]) | ||
|
|
There was a problem hiding this comment.
use pd.option_context as a context manager instead
jreback
reviewed
Feb 24, 2017
pandas/tests/sparse/test_format.py
Outdated
| try: | ||
| repr(sdf) | ||
| finally: | ||
| pd.core.config.set_option('mode.chained_assignment', old_opt) |
There was a problem hiding this comment.
also can you use assert_sp_frame_equal and compare
jreback
added
Indexing
|
ok, lgtm. ping on green. |
|
It's green. |
|
thanks @kernc keep em coming! |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
closes pandas-dev#15488 Author: Kernc <kerncece@gmail.com> Closes pandas-dev#15489 from kernc/sdf-repr and squashes the following commits: 2dc145c [Kernc] BUG: repr SparseDataFrame after setting a value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff