Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: DataFrame.hist() does not get along with matplotlib.pyplot.tight_layout() #15515

Merged
merged 4 commits into from
Feb 27, 2017
Merged

TST: DataFrame.hist() does not get along with matplotlib.pyplot.tight_layout() #15515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5909635
Add unit test for #9351
ResidentMario Feb 27, 2017
fc0c177
Tweaks.
ResidentMario Feb 27, 2017
02a8eff
add _check_plot_works; rm aux method
ResidentMario Feb 27, 2017
809d847
Add whatsnew entry.
ResidentMario Feb 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.20.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ Bug Fixes




- Bug in ``DataFrame.hist`` where ``plt.tight_layout`` caused an ``AttributeError`` (use ``matplotlib >= 0.2.0``) (:issue:`9351`)
- Bug in ``DataFrame.boxplot`` where ``fontsize`` was not applied to the tick labels on both axes (:issue:`15108`)
- Bug in ``Series.replace`` and ``DataFrame.replace`` which failed on empty replacement dicts (:issue:`15289`)
- Bug in ``pd.melt()`` where passing a tuple value for ``value_vars`` caused a ``TypeError`` (:issue:`15348`)
Expand Down
10 changes: 10 additions & 0 deletions pandas/tests/plotting/test_hist_method.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,16 @@ def test_hist_layout(self):
with tm.assertRaises(ValueError):
df.hist(layout=(-1, -1))

@slow
# GH 9351
def test_tight_layout(self):
if self.mpl_ge_2_0_0:
df = DataFrame(randn(100, 2))
_check_plot_works(df.hist)
self.plt.tight_layout()

tm.close()


@tm.mplskip
class TestDataFrameGroupByPlots(TestPlotBase):
Expand Down