CLN: remove pandas.core.categorical

[simonjayhawkins]

xref #19269

pandas/pandas/core/categorical.py

Line 7 in de52d0b

# TODO: Remove after 0.23.x

[codecov]

Codecov Report

Merging #25655 into master will decrease coverage by 49.55%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #25655       +/-   ##
===========================================
- Coverage   91.29%   41.74%   -49.56%     
===========================================
  Files         173      172        -1     
  Lines       52961    52957        -4     
===========================================
- Hits        48350    22106    -26244     
- Misses       4611    30851    +26240

Flag	Coverage Δ
#multiple	?
#single	41.74% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/io/formats/latex.py	0% <0%> (-100%)	⬇️
pandas/io/sas/sas_constants.py	0% <0%> (-100%)	⬇️
pandas/tseries/plotting.py	0% <0%> (-100%)	⬇️
pandas/tseries/converter.py	0% <0%> (-100%)	⬇️
pandas/io/formats/html.py	0% <0%> (-99.36%)	⬇️
pandas/core/groupby/categorical.py	0% <0%> (-95.46%)	⬇️
pandas/io/sas/sas7bdat.py	0% <0%> (-91.17%)	⬇️
pandas/io/sas/sas_xport.py	0% <0%> (-90.15%)	⬇️
pandas/core/tools/numeric.py	10.44% <0%> (-89.56%)	⬇️
pandas/io/json/normalize.py	8.16% <0%> (-88.78%)	⬇️
... and 129 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de52d0b...924b60a. Read the comment docs.

[codecov]

Codecov Report

Merging #25655 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25655      +/-   ##
==========================================
- Coverage   91.29%   91.29%   -0.01%     
==========================================
  Files         173      172       -1     
  Lines       52961    52957       -4     
==========================================
- Hits        48350    48345       -5     
- Misses       4611     4612       +1

Flag	Coverage Δ
#multiple	89.86% <ø> (-0.01%)	⬇️
#single	41.74% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/util/testing.py	88.98% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de52d0b...924b60a. Read the comment docs.

[jbrockmendel]

LGTM. Did you grep for all the “remove after ...” comments?

[simonjayhawkins]

a quick grep yields:

pandas/compat/pickle_compat.py:    # TODO: When FrozenNDArray is removed, add
pandas/core/arrays/datetimelike.py:        # TODO(GH-20300): remove this
pandas/core/arrays/numpy_.py:# TODO(NumPy1.13): remove this
pandas/core/arrays/numpy_.py:        # TODO(_values_for_fillna): remove this
pandas/core/arrays/period.py:        # TODO: remove
pandas/core/arrays/sparse.py:        # TODO(SparseArray.__setitem__): remove special cases in
pandas/core/indexes/api.py:                    # TODO: remove once pd.concat sort default changes
pandas/core/indexes/base.py:        # TODO(EA): remove index types as they become extension arrays
pandas/core/indexes/period.py:        # TODO(DatetimeArray): remove
pandas/core/internals/blocks.py:            # TODO(SparseArray.__setitem__): remove this if condition
pandas/core/internals/blocks.py:    # TODO: Refactor when convert_objects is removed since there will be 1 path
pandas/core/internals/blocks.py:                    # TODO(ExtensionArray): remove is_extension_type
pandas/core/series.py:            # TODO: remove when the default Categorical.take behavior changes
pandas/core/sparse/series.py:        # TODO: remove?
pandas/io/formats/html.py:                # TODO: Refactor to remove code duplication with code
pandas/io/formats/html.py:            # TODO: Refactor to remove code duplication with code block
pandas/plotting/_core.py:    # TODO(mpl_converter): remove once converter is explicit
pandas/tests/extension/test_categorical.py:        # TODO remove this once Categorical.take is fixed
pandas/tests/extension/test_numpy.py:    @pytest.mark.skip(reason="TODO: remove?")
pandas/tests/frame/test_to_csv.py:            # TODO: remove renaming when GH 10875 is solved
pandas/tests/sparse/series/test_series.py:        # TODO: sp_zero is not used anywhere...remove?
pandas/tests/sparse/series/test_series.py:            # TODO: expected is not used anywhere...remove?
pandas/util/_validators.py:    # TODO(PY3): Change to keyword-only args and remove all this

nothing jumps out as being related.

[jreback]

thanks @simonjayhawkins