Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ValueError message in corr #25729

Merged
merged 4 commits into from Mar 14, 2019

Conversation

@fabianrost84
Copy link
Contributor

commented Mar 14, 2019

to include the option of supplying a callable.

  • closes #25727
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
Update ValueError message in corr
to include the option of supplying a callable.

@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Mar 14, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 14, 2019

Codecov Report

Merging #25729 into master will decrease coverage by 49.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25729      +/-   ##
==========================================
- Coverage   91.24%   41.75%   -49.5%     
==========================================
  Files         172      172              
  Lines       52973    52973              
==========================================
- Hits        48337    22117   -26220     
- Misses       4636    30856   +26220
Flag Coverage Δ
#multiple ?
#single 41.75% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 34.79% <ø> (-62.01%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.36%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d251d...d354be9. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Mar 14, 2019

Codecov Report

Merging #25729 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25729      +/-   ##
==========================================
+ Coverage   91.24%   91.25%   +<.01%     
==========================================
  Files         172      172              
  Lines       52973    52973              
==========================================
+ Hits        48337    48338       +1     
+ Misses       4636     4635       -1
Flag Coverage Δ
#multiple 89.82% <ø> (ø) ⬆️
#single 41.74% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 96.79% <ø> (ø) ⬆️
pandas/core/series.py 93.68% <ø> (ø) ⬆️
pandas/util/testing.py 89.08% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d251d...d354be9. Read the comment docs.

@jreback jreback merged commit 64f5961 into pandas-dev:master Mar 14, 2019

11 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190314.22 succeeded
Details
pandas-dev.pandas (Checks_and_doc) Checks_and_doc succeeded
Details
pandas-dev.pandas (Linux py27_locale_slow_old_np) Linux py27_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py27_np_120) Linux py27_np_120 succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow) Linux py36_locale_slow succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
pandas-dev.pandas (Windows py27_np121) Windows py27_np121 succeeded
Details
pandas-dev.pandas (Windows py36_np14) Windows py36_np14 succeeded
Details
pandas-dev.pandas (macOS py35_np_120) macOS py35_np_120 succeeded
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

thanks @fabianrost84

sighingnow added a commit to sighingnow/pandas that referenced this pull request Mar 14, 2019

Merge branch 'master' into fix-25587
* master: (22 commits)
  Fixturize tests/frame/test_operators.py (pandas-dev#25641)
  Update ValueError message in corr (pandas-dev#25729)
  DOC: fix some grammar and inconsistency issues in the User Guide (pandas-dev#25728)
  ENH: Add public start, stop, and step attributes to RangeIndex (pandas-dev#25720)
  Make Rolling.apply documentation clearer (pandas-dev#25712)
  pandas-dev#25707 - Fixed flakiness in stata write test (pandas-dev#25714)
  Json normalize nan support (pandas-dev#25619)
  TST: resolve issues with test_constructor_dtype_datetime64 (pandas-dev#24868)
  DEPR: Deprecate box kwarg for to_timedelta and to_datetime (pandas-dev#24486)
  BUG: Preserve name in DatetimeIndex.snap (pandas-dev#25585)
  Fix concat not respecting order of OrderedDict (pandas-dev#25224)
  CLN: remove pandas.core.categorical (pandas-dev#25655)
  TST/CLN: Remove more Panel tests (pandas-dev#25675)
  Pinned pycodestyle (pandas-dev#25701)
  DOC: update date of 0.24.2 release notes (pandas-dev#25699)
  BUG: Fix error in replace with strings that are large numbers (pandas-dev#25616) (pandas-dev#25644)
  BUG: fix usage of na_sentinel with sort=True in factorize() (pandas-dev#25592)
  BUG: Fix to_string output when using header (pandas-dev#16718) (pandas-dev#25602)
  CLN: Remove unused test code (pandas-dev#25670)
  CLN: remove Panel from concat error message (pandas-dev#25676)
  ...

# Conflicts:
#	doc/source/whatsnew/v0.25.0.rst

sighingnow added a commit to sighingnow/pandas that referenced this pull request Mar 14, 2019

Merge branch 'master' into fix-25691
* master:
  Fixturize tests/frame/test_operators.py (pandas-dev#25641)
  Update ValueError message in corr (pandas-dev#25729)

# Conflicts:
#	doc/source/whatsnew/v0.25.0.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.