BUG: Fixed bug, where pandas._libs.lib.maybe_convert_objects function improperly handled arrays with bools and NaNs #32242
Conversation
… improperly handled arrays with bools and NaNs
WillAyd
added
the
NA - MaskedArrays
simonjayhawkins
added
the
Regression
|
Hello @AnnaDaglis! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-04 13:58:45 UTC |
…ith_nans_issue Fix Series representation of an object Index with bools and NaN
|
@jreback All tests passed. |
| ), | ||
| ], | ||
| ) | ||
| def test_value_counts_bool_with_nan(self, ser, dropna, exp): |
There was a problem hiding this comment.
I may have misunderstood the original issue, but my understanding is that the values were correct, just the repr was wrong. If so, why are we adding new tests here, which I think don't cover the reported issue?
There was a problem hiding this comment.
Ah, I see it was requested by @jreback in https://github.com/pandas-dev/pandas/pull/32242/files#r385098106. I suppose no harm in more tests, but don't we think this is already tested?
There was a problem hiding this comment.
@TomAugspurger Yes, I agree that this has been tested. Was following the suggestion of @jreback.
There was a problem hiding this comment.
@jreback can you comment on the request / need for these tests?
Co-Authored-By: Tom Augspurger <TomAugspurger@users.noreply.github.com>
…AnnaDaglis/pandas into fix_index_bools_with_nans_issue
…ith_nans_issue Fixed bug in the repr of an object-dtype with bools and missing values
|
@TomAugspurger @jreback All tests passed. |
| ), | ||
| ], | ||
| ) | ||
| def test_value_counts_bool_with_nan(self, ser, dropna, exp): |
There was a problem hiding this comment.
@jreback can you comment on the request / need for these tests?
|
Ok, let's merge this. Having extra tests probably isn't a bad thing :) Thanks @AnnaDaglis, and congrats on your first PR to pandas! |
…maybe_convert_objects function improperly handled arrays with bools and NaNs
|
Thanks @AnnaDaglis ! |
…ert_objects function improperly handled arrays with bools and NaNs (#32552) Co-authored-by: Anna Daglis <40292327+AnnaDaglis@users.noreply.github.com>
… improperly handled arrays with bools and NaNs (pandas-dev#32242) * BUG: Fixed bug, where pandas._libs.lib.maybe_convert_objects function improperly handled arrays with bools and NaNs
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff