Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: clean up new detected trailing whitespace #36588

Merged
merged 4 commits into from
Oct 18, 2020

Conversation

plammens
Copy link
Contributor

  • [N/A] closes #xxxx (xref #36386 (comment))
  • [N/A] tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [N/A] whatsnew entry

Fixed the remaining trailing whitespace problems that weren't being found by ci/code_checks.sh because of the file type filters.

Copy link
Member

@dsaxton dsaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @plammens

@MarcoGorelli
Copy link
Member

Would it work to add the trailing-whitespace hook from https://github.com/pre-commit/pre-commit-hooks ?

@MarcoGorelli
Copy link
Member

Might need some of the same exclusions as for the end-of-file-fixer (maybe just svg and html?)

@plammens
Copy link
Contributor Author

Might need some of the same exclusions as for the end-of-file-fixer (maybe just svg and html?)

Yeah just noticed that after pushing, was going to fix but something else came up. Should be all done now 🙂

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @plammens !

@MarcoGorelli
Copy link
Member

Thanks @plammens !

@MarcoGorelli MarcoGorelli merged commit 75a5fa7 into pandas-dev:master Oct 18, 2020
@MarcoGorelli MarcoGorelli added this to the 1.2 milestone Oct 18, 2020
@MarcoGorelli MarcoGorelli added Code Style Code style, linting, code_checks and removed Clean labels Oct 18, 2020
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
* CLN: clean up new detected trailing whitespace

* BLD: add `trailing-whitespace` pre-commit hook

* Update .pre-commit-config.yaml

Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
* CLN: clean up new detected trailing whitespace

* BLD: add `trailing-whitespace` pre-commit hook

* Update .pre-commit-config.yaml

Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants