-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: clean up new detected trailing whitespace #36588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @plammens
Would it work to add the |
47ad3b4
to
4fc65fa
Compare
Might need some of the same exclusions as for the end-of-file-fixer (maybe just svg and html?) |
4fc65fa
to
4dd1d49
Compare
Yeah just noticed that after pushing, was going to fix but something else came up. Should be all done now 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @plammens !
Thanks @plammens ! |
* CLN: clean up new detected trailing whitespace * BLD: add `trailing-whitespace` pre-commit hook * Update .pre-commit-config.yaml Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
* CLN: clean up new detected trailing whitespace * BLD: add `trailing-whitespace` pre-commit hook * Update .pre-commit-config.yaml Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Fixed the remaining trailing whitespace problems that weren't being found by
ci/code_checks.sh
because of the file type filters.