Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Clarified pandas_version in to_json #37025

Merged
merged 4 commits into from
Oct 14, 2020
Merged

DOC: Clarified pandas_version in to_json #37025

merged 4 commits into from
Oct 14, 2020

Conversation

tnwei
Copy link
Contributor

@tnwei tnwei commented Oct 10, 2020 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Oct 10, 2020 •
edited
Loading

Hello @tnwei! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-12 15:07:54 UTC

arw2019
arw2019 reviewed Oct 10, 2020
View reviewed changes
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tnwei for the PR!

pandas/core/generic.py Outdated Show resolved Hide resolved
pandas/core/generic.py Outdated Show resolved Hide resolved
@tnwei
Copy link
Contributor Author

tnwei commented Oct 10, 2020

Thanks @arw2019 for the review, edited wording as suggested

jreback
jreback requested changes Oct 10, 2020
View reviewed changes
pandas/core/generic.py Outdated Show resolved Hide resolved
@jreback jreback added Docs IO JSON read_json, to_json, json_normalize labels Oct 10, 2020
@jreback jreback added this to the 1.2 milestone Oct 14, 2020
@jreback jreback merged commit 2806e7d into pandas-dev:master Oct 14, 2020
@jreback
Copy link
Contributor

jreback commented Oct 14, 2020

thanks @tnwei

@tnwei
Copy link
Contributor Author

tnwei commented Oct 14, 2020

Thanks for merging @jreback . Hacktoberfest brought me here, would you mind adding the hacktoberfest-accepted label to this PR? TQVM!

@jreback
Copy link
Contributor

jreback commented Oct 14, 2020

Thanks for merging @jreback . Hacktoberfest brought me here, would you mind adding the hacktoberfest-accepted label to this PR? TQVM!

no problem

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@tnwei @JulianWgs
DOC: Clarified pandas_version in to_json (pandas-dev#37025)
d35ab7f
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@tnwei
DOC: Clarified pandas_version in to_json (pandas-dev#37025)
a89bc51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arw2019 arw2019 arw2019 approved these changes

@mroeschke mroeschke mroeschke approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Docs IO JSON read_json, to_json, json_normalize
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

Improve docs for pandas_version in Dataframe to_json(orient='table')
5 participants
@tnwei @pep8speaks @jreback @mroeschke @arw2019