BUG: preserve timezone info when writing empty tz-aware frame to HDF5 #37069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
arw2019
added a commit
to arw2019/pandas
that referenced
this pull request
Oct 12, 2020
arw2019
added a commit
to arw2019/pandas
that referenced
this pull request
Oct 12, 2020
|
looks like dupe of #37072 |
jreback
added
Duplicate Report
|
sorry just read the comment on the other PR |
jreback
requested changes
Oct 14, 2020
|
Green. |
jreback
approved these changes
Oct 15, 2020
| @@ -296,6 +296,16 @@ def test_timezones_fixed(setup_path): | |||
| tm.assert_frame_equal(result, df) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("dtype", ["datetime64[ns, UTC]", "datetime64[ns, US/Eastern]"]) | |||
There was a problem hiding this comment.
next PR can you change this to use the tz_aware_fixture
|
thanks @arw2019 |
arw2019
added a commit
to arw2019/pandas
that referenced
this pull request
Oct 15, 2020
arw2019
added a commit
to arw2019/pandas
that referenced
this pull request
Oct 17, 2020
arw2019
added a commit
to arw2019/pandas
that referenced
this pull request
Oct 17, 2020
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffWill handle series case in follow-on