REF/TYP: pandas/core/window/*.py #37091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Typing
jreback
requested changes
Oct 14, 2020
pandas/core/window/expanding.py
Outdated
| args=None, | ||
| kwargs=None, | ||
| args: Optional[Tuple] = None, | ||
| kwargs: Optional[Dict] = None, |
There was a problem hiding this comment.
we will eventually want to use disallow_any_generic as we increase strictness checks xref #30539
so for kwargs could probably use Dict[str, Any] and for args, Tuple[Any, ...]
can you also add type parameters to Callable.
jreback
approved these changes
Oct 15, 2020
jreback
reviewed
Oct 15, 2020
| @@ -60,6 +64,15 @@ def get_center_of_mass( | |||
| return float(comass) | |||
|
|
|||
|
|
|||
| def wrap_result(obj: "Series", result: np.ndarray) -> "Series": | |||
There was a problem hiding this comment.
for clarify should make this wrap_result_1d, but can be in the future
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffWindowvsRolling