Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: test for expanding window with min_periods GH25857 #37131

Merged
merged 1 commit into from
Oct 16, 2020
Merged

TST: test for expanding window with min_periods GH25857 #37131

merged 1 commit into from
Oct 16, 2020

Conversation

theMogget
Copy link
Contributor

@theMogget theMogget commented Oct 15, 2020 •
edited
Loading

Hi @mroeschke, here's the new test - please let me know if it needs any changes.

@jreback jreback added Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding labels Oct 15, 2020
@jreback jreback added this to the 1.2 milestone Oct 15, 2020
@jreback
Copy link
Contributor

jreback commented Oct 15, 2020

@mroeschke should close the OP ?

mroeschke
mroeschke approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM

@jreback jreback merged commit e719538 into pandas-dev:master Oct 16, 2020
@jreback
Copy link
Contributor

jreback commented Oct 16, 2020

thanks @theMogget

@theMogget
Copy link
Contributor Author

Thanks! Could anyone help at the hacktoberfest-accepted label to this please? :)

@simonjayhawkins
Copy link
Member

Thanks @theMogget. added.

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@theMogget @JulianWgs
TST: test for expanding window with min_periods GH25857 (pandas-dev#3…
ade8a65 
…7131)
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@theMogget
TST: test for expanding window with min_periods GH25857 (pandas-dev#3…
34d7a58 
…7131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

expanding(min_periods=N).count(), for any N, returns same result as expanding(min_periods=1).count()
4 participants
@theMogget @jreback @simonjayhawkins @mroeschke