Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: DataFrame __divmod__, __rdivmod__ #37165

Merged
merged 3 commits into from
Oct 17, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this new? or just a better definition for the op? (e.g. do you need a whatsnew)

@@ -5960,6 +5960,18 @@ def _construct_result(self, result) -> DataFrame:
out.index = self.index
return out

def __divmod__(self, other):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't these be with other arith operators?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the arithmetic section

@@ -5960,6 +5960,18 @@ def _construct_result(self, result) -> DataFrame:
out.index = self.index
return out

def __divmod__(self, other):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you type

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@jreback jreback added the Numeric Operations Arithmetic, Comparison, and Logical operations label Oct 16, 2020
@jreback jreback added this to the 1.2 milestone Oct 16, 2020
@jbrockmendel
Copy link
Member Author

is this new? or just a better definition for the op? (e.g. do you need a whatsnew)

new, will add whatsnew

@jreback jreback merged commit 56f03c7 into pandas-dev:master Oct 17, 2020
@jbrockmendel jbrockmendel deleted the enh-divmod branch October 17, 2020 15:09
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants