Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: ensure we pass correct type to DTI/TDI shallow_copy #37171

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added Clean Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays. labels Oct 17, 2020
@jreback jreback added this to the 1.2 milestone Oct 17, 2020
@jreback jreback merged commit 7f910b5 into pandas-dev:master Oct 17, 2020
@jbrockmendel jbrockmendel deleted the clners branch October 17, 2020 15:10
@jorisvandenbossche
Copy link
Member

This seems to have caused a performance regression, see https://pandas.pydata.org/speed/pandas/#index_object.SetDisjoint.time_datetime_difference_disjoint?Cython=0.29.21&python=3.8&x-axis-scale=date

Example from the benchmark:

In [5]: N = 10 ** 5
   ...: B = N + 20000
   ...: datetime_left = pd.DatetimeIndex(range(N))
   ...: datetime_right = pd.DatetimeIndex(range(N, B))

In [6]: %timeit datetime_left.difference(datetime_right)
3.27 ms ± 230 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

(note I didn't verify it's this commit, but it seems the most related one in the last days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants