Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Simplify creation of rolling window indexers internally #37177

Merged

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@mroeschke mroeschke added Refactor Internal refactoring of code Window rolling, ewma, expanding labels Oct 16, 2020
@mroeschke mroeschke added this to the 1.2 milestone Oct 16, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm merge on green.

@mroeschke mroeschke merged commit a8e2f92 into pandas-dev:master Oct 17, 2020
@mroeschke mroeschke deleted the ref/window_indexer_construction branch October 17, 2020 01:00
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
…7177)

Co-authored-by: Matt Roeschke <mroeschke@housecanary.com>
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
…7177)

Co-authored-by: Matt Roeschke <mroeschke@housecanary.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants