Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Add example to Series.divmod #37185

Merged
merged 1 commit into from
Oct 17, 2020
Merged

DOC: Add example to Series.divmod #37185

merged 1 commit into from
Oct 17, 2020

Conversation

hongshaoyang
Copy link
Contributor

@hongshaoyang hongshaoyang commented Oct 17, 2020 •
edited
Loading

Current doc; Rendered doc:
Screenshot 2020-10-17 at 10 44 26 AM

arw2019
arw2019 approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hongshaoyang for the PR!

LGTM

Totally optional, just in case you feel like it, I think that a example using the level keyword would be great (although of course this is an improvement as is!)

@jreback jreback added the Docs label Oct 17, 2020
@jreback jreback added this to the 1.2 milestone Oct 17, 2020
@jreback jreback added the Numeric Operations Arithmetic, Comparison, and Logical operations label Oct 17, 2020
@jreback jreback merged commit 0a5a3a7 into pandas-dev:master Oct 17, 2020
@jreback
Copy link
Contributor

jreback commented Oct 17, 2020

thanks @hongshaoyang

@hongshaoyang hongshaoyang deleted the 24589-divmod branch October 17, 2020 13:39
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@hongshaoyang @JulianWgs
DOC: Add example to Series.divmod (pandas-dev#37185)
dd77904
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@hongshaoyang
DOC: Add example to Series.divmod (pandas-dev#37185)
bbf8612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arw2019 arw2019 arw2019 approved these changes

Assignees
No one assigned
Labels
Docs Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

Examples for Series ops should be specific to each method.
3 participants
@hongshaoyang @jreback @arw2019