Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add value counts as related method to count #37209

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

erictleung
Copy link
Contributor

Counting values using .value_counts(), more generally, is a counting task, so it felt natural to link the .count() page to .value_counts().

I copied the description for .value_counts() from the "See also" box in .drop_duplicates().

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@erictleung erictleung closed this Oct 17, 2020
@erictleung erictleung reopened this Oct 17, 2020
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback added the Docs label Oct 22, 2020
@jreback jreback added this to the 1.2 milestone Oct 22, 2020
@jreback jreback merged commit f590254 into pandas-dev:master Oct 22, 2020
@jreback
Copy link
Contributor

jreback commented Oct 22, 2020

thanks @erictleung

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@erictleung erictleung deleted the add-see-also-value-counts branch November 9, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants