Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Updated resample.py and groupby.py to fix SA04 Errors #37219

Merged
merged 9 commits into from
Oct 29, 2020
Merged

DOC: Updated resample.py and groupby.py to fix SA04 Errors #37219

merged 9 commits into from
Oct 29, 2020

Conversation

nagesh-chowdaiah
Copy link
Contributor

@nagesh-chowdaiah nagesh-chowdaiah commented Oct 18, 2020 •
edited

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry: Fixed Partial SA04 Errors

@pep8speaks
Copy link

pep8speaks commented Oct 18, 2020 •
edited

Hello @nagesh-chowdaiah! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-23 07:52:28 UTC

@nagesh-chowdaiah nagesh-chowdaiah mentioned this pull request Oct 18, 2020
Closed
@nagesh-chowdaiah
Copy link
Contributor Author

nagesh-chowdaiah commented Oct 18, 2020 •
edited

@simonjayhawkins can you explain me on this test errors. I just updated the docs and logic is not changed. but still the pipelines are failing

@nagesh-chowdaiah
Copy link
Contributor Author

@jreback Fixed all the issues or SA04 errors.

jreback
jreback requested changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know the answer here about the docs strings maybe
@simonjayhawkins or @jorisvandenbossche does (e.g. does the indent matter / should we be consistent etc)

pandas/_libs/tslibs/timedeltas.pyx Outdated Show resolved Hide resolved
pandas/core/dtypes/base.py Outdated Show resolved Hide resolved
pandas/core/resample.py Outdated Show resolved Hide resolved
@jreback jreback added this to the 1.2 milestone Oct 20, 2020
jorisvandenbossche
jorisvandenbossche reviewed Oct 21, 2020
View reviewed changes
pandas/_libs/tslibs/timedeltas.pyx Outdated Show resolved Hide resolved
pandas/core/arrays/boolean.py Outdated Show resolved Hide resolved
pandas/core/arrays/integer.py Outdated Show resolved Hide resolved
nagesh-chowdaiah and others added 3 commits October 21, 2020 14:30
@nagesh-chowdaiah @jorisvandenbossche
Update pandas/core/arrays/integer.py
d21675a 
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@nagesh-chowdaiah @jorisvandenbossche
Update pandas/core/arrays/boolean.py
df28152 
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@nagesh-chowdaiah
pandas-dev#28792 DOC: udpated reviewers comments
4ca7957
@nagesh-chowdaiah
Copy link
Contributor Author

@jreback and @jorisvandenbossche i have fixed the suggested chagnes.

@jreback
Copy link
Contributor

jreback commented Oct 23, 2020

can you merge master and ping on green.

@simonjayhawkins
Copy link
Member

Windows py37_np16 unrelated see #37328

=========================== short test summary info ===========================
FAILED pandas/tests/computation/test_eval.py::TestEvalNumexprPython::test_binary_arith_ops[4-3-/]
= 1 failed, 96826 passed, 4046 skipped, 1425 xfailed, 1 xpassed, 105 warnings in 1454.58s (0:24:14) =

Windows py38_np18 failure

FATAL ERROR: Committing semi space failed. Allocation failed - process out of memory

restarting ci

@nagesh-chowdaiah
Copy link
Contributor Author

@jreback and @simonjayhawkins does this needs a wait on #37328 to get merged

@nagesh-chowdaiah
Copy link
Contributor Author

@jreback can you please merge this PR and can you please add the tag hacktoberfest-accepted. I am participating in that.. would be great if you can help in achieving that target

@jreback jreback merged commit 290c58a into pandas-dev:master Oct 29, 2020
@jreback
Copy link
Contributor

jreback commented Oct 29, 2020

thanks @nagesh-chowdaiah

@nagesh-chowdaiah nagesh-chowdaiah deleted the 28792_Fix_SA04_errors branch October 29, 2020 16:07
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@nagesh-chowdaiah @nagesh-kumar-abinbev
@jorisvandenbossche @simonjayhawkins
DOC: Updated resample.py and groupby.py to fix SA04 Errors (pandas-de…
fded0c4 
…v#37219)

* DOC: Updated resample.py and groupby.py to fix SA04 Errors

* DOC: Fixed flake8 issue

* pandas-dev#28792 DOC: Fixed SA04 Errors

* pandas-dev#28792 Doc Fix SA04 Errors

* Update pandas/core/arrays/integer.py

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

* Update pandas/core/arrays/boolean.py

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

* pandas-dev#28792 DOC: udpated reviewers comments

* pandas-dev#28792 DOC: Fixing flake8 Errors

Co-authored-by: Nagesh Kumar C <Nageshkumar.c@ab-inbev.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
ukarroum pushed a commit to ukarroum/pandas that referenced this pull request Nov 2, 2020
@nagesh-chowdaiah @nagesh-kumar-abinbev
@jorisvandenbossche @simonjayhawkins @ukarroum
DOC: Updated resample.py and groupby.py to fix SA04 Errors (pandas-de…
deb29dd 
…v#37219)

* DOC: Updated resample.py and groupby.py to fix SA04 Errors

* DOC: Fixed flake8 issue

* pandas-dev#28792 DOC: Fixed SA04 Errors

* pandas-dev#28792 Doc Fix SA04 Errors

* Update pandas/core/arrays/integer.py

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

* Update pandas/core/arrays/boolean.py

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

* pandas-dev#28792 DOC: udpated reviewers comments

* pandas-dev#28792 DOC: Fixing flake8 Errors

Co-authored-by: Nagesh Kumar C <Nageshkumar.c@ab-inbev.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Docs Groupby Resample resample method
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nagesh-chowdaiah @pep8speaks @jreback @simonjayhawkins @jorisvandenbossche @nagesh-kumar-abinbev