Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: clean-up test on addition of series/frames #37238

Merged
merged 1 commit into from
Oct 20, 2020
Merged

CLN: clean-up test on addition of series/frames #37238

merged 1 commit into from
Oct 20, 2020

Conversation

ivanovmg
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Cleanup in pandas/tests/arithmetic/test_numeric.py.

  • Split test_arith_ops_df_compat into test_add_series and test_add_frames.
  • Parametrize tests.

@jreback jreback added Numeric Operations Arithmetic, Comparison, and Logical operations Testing pandas testing functions or related to the test suite labels Oct 20, 2020
@jreback jreback added this to the 1.2 milestone Oct 20, 2020
@jreback jreback merged commit f23f8ac into pandas-dev:master Oct 20, 2020
@jreback
Copy link
Contributor

jreback commented Oct 20, 2020

thanks @ivanovmg

@ivanovmg ivanovmg deleted the cleanup/arithmetic3 branch October 20, 2020 05:47
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@ivanovmg @JulianWgs
CLN: clean-up test on addition of series/frames (pandas-dev#37238)
37c1161
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@ivanovmg
CLN: clean-up test on addition of series/frames (pandas-dev#37238)
a6f4d05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanovmg @jreback