Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI move code directives to pre-commit, remove some outdated checks #37241

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Oct 19, 2020

Moving checks for incorrect code block or IPython directives to pre-commit so they're cross-platform and give faster feedback to devs.

Also removing some no-longer-necessary code checks:

  • "Check that no file in the repo contains trailing whitespaces" is taken care of by the trailing-whitespace hook
  • "Check for extra blank lines after the class definition" is enforced by black

@jbrockmendel
Copy link
Member

LGTM pending green

@jreback jreback added CI Continuous Integration Code Style Code style, linting, code_checks labels Oct 20, 2020
@jreback jreback added this to the 1.2 milestone Oct 20, 2020
@jreback jreback merged commit c3f1e7f into pandas-dev:master Oct 20, 2020
@jreback
Copy link
Contributor

jreback commented Oct 20, 2020

thanks @MarcoGorelli

@MarcoGorelli MarcoGorelli deleted the incorrect-directies branch October 20, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants