Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGR: Make comparisons consistent for PeriodDtype #37270

Merged
merged 1 commit into from
Oct 20, 2020
Merged

REGR: Make comparisons consistent for PeriodDtype #37270

merged 1 commit into from
Oct 20, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Oct 20, 2020

@dsaxton dsaxton added Dtype Conversions Unexpected or buggy dtype conversions Regression Functionality that used to work in a prior pandas version Period Period data type labels Oct 20, 2020
@dsaxton dsaxton added this to the 1.1.4 milestone Oct 20, 2020
@jbrockmendel
Copy link
Member

LGTM

@jreback jreback merged commit ce5a112 into pandas-dev:master Oct 20, 2020
@jreback
Copy link
Contributor

jreback commented Oct 20, 2020

thanks @dsaxton

@dsaxton dsaxton deleted the period-dtype-equal-string branch October 20, 2020 17:15
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

@lumberbot-app

This comment has been minimized.

Sign in to view
@simonjayhawkins
Copy link
Member

probably conflicts on the whatsnew with #37198, but the backport #37305 can't be merged just yet. #37305 (review)

simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Oct 21, 2020
@dsaxton @simonjayhawkins
Backport PR pandas-dev#37270 on branch 1.1.x: REGR: Make comparisons …
7aa6c36 
…consistent for PeriodDtype
@simonjayhawkins simonjayhawkins mentioned this pull request Oct 21, 2020
Merged
simonjayhawkins added a commit that referenced this pull request Oct 21, 2020
@simonjayhawkins @dsaxton
Backport PR #37270 on branch 1.1.x: REGR: Make comparisons consistent…
9fe01dd 
… for PeriodDtype (#37307)

Co-authored-by: Daniel Saxton <2658661+dsaxton@users.noreply.github.com>
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@dsaxton @JulianWgs
REGR: Make comparisons consistent for PeriodDtype (pandas-dev#37270)
709426d
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@dsaxton
REGR: Make comparisons consistent for PeriodDtype (pandas-dev#37270)
93080e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Period Period data type Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.1.4
Development

Successfully merging this pull request may close these issues.

BUG: PeriodIndex.dtype comparison with string exhibits contradiction
4 participants
@dsaxton @jbrockmendel @jreback @simonjayhawkins