REF/TST: collect astype tests #37282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Dtype Conversions
jreback
requested changes
Oct 20, 2020
| @@ -1,123 +1,21 @@ | |||
| from datetime import datetime, timedelta | |||
| from importlib import reload | |||
There was a problem hiding this comment.
what exactly is left over here? i am not sure i get why you are moving to a new file than just renaming and moving out anything that isn't astype (which is a very small number)
There was a problem hiding this comment.
9 tests left here for which i havent found a home, but it definitely isnt test_astype. one probably belongs in the DataFrame tests, one for reindex, one for constructors...
i do expect this file to be killed off before too long
There was a problem hiding this comment.
ok its fine, just though would be easier to rename
but ok
jreback
approved these changes
Oct 20, 2020
|
hmm i think this one is actually failing some CI (that IS related) e.g. CI/web and docs is failing |
|
can you rebase |
|
rebased+green |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff