Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add protocol value '5' to pickle #37316 #37322

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

botplex
Copy link
Contributor

@botplex botplex commented Oct 21, 2020

@jreback jreback added the Docs label Oct 22, 2020
@jreback jreback added this to the 1.2 milestone Oct 22, 2020
@jreback jreback merged commit ef5ccfd into pandas-dev:master Oct 22, 2020
@jreback
Copy link
Contributor

jreback commented Oct 22, 2020

thanks @botplex

@botplex
Copy link
Contributor Author

botplex commented Oct 22, 2020

The issue is still there as visible here: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.to_pickle.html
I should have changed the code in the branch named 1.1.x https://github.com/pandas-dev/pandas/blob/v1.1.3/pandas/core/generic.py instead of master

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: to_pickle function takes pickle v5 but doc says only 1-4 supported
2 participants