Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: extract dialect validation #37332

Merged
merged 1 commit into from
Oct 23, 2020
Merged

REF: extract dialect validation #37332

merged 1 commit into from
Oct 23, 2020

Conversation

ivanovmg
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Following #36852, I extracted validation of dialect into a separate function.

@jreback jreback added IO CSV read_csv, to_csv Refactor Internal refactoring of code labels Oct 23, 2020
@jreback jreback added this to the 1.2 milestone Oct 23, 2020
@jreback jreback merged commit 9fe5dba into pandas-dev:master Oct 23, 2020
@jreback
Copy link
Contributor

jreback commented Oct 23, 2020

sure

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@ivanovmg @JulianWgs
REF: extract dialect validation (pandas-dev#37332)
9e31244
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@ivanovmg
REF: extract dialect validation (pandas-dev#37332)
24f8a0d
@ivanovmg ivanovmg deleted the refactor/parsers branch November 6, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO CSV read_csv, to_csv Refactor Internal refactoring of code
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanovmg @jreback